Skip to content

MdePkg: Add MockSynchronizationLib and MockSmmSxDispatch2 #11034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

MdePkg: Add MockSynchronizationLib and MockSmmSxDispatch2 #11034

wants to merge 2 commits into from

Conversation

@TsunFengHuang
Copy link

Description

MdePkg: Add MockSynchronizationLib and MockSmmSxDispatch2

  • Breaking change?
    • Breaking change - Does this PR cause a break in build or boot behavior?
    • Examples: Does it add a new library class or move a module to a different repo.
  • Impacts security?
    • Security - Does this PR have a direct security impact?
    • Examples: Crypto algorithm change or buffer overflow fix.
  • Includes tests?
    • Tests - Does this PR include any explicit test code?
    • Examples: Unit tests or integration tests.

How This Was Tested

Unit tests component can call these mock functions success

Integration Instructions

N/A

@TsunFengHuang TsunFengHuang force-pushed the personal/TsunFeng/MockAdded branch 6 times, most recently from 960e796 to 1821228 Compare May 5, 2025 07:26
@TsunFengHuang TsunFengHuang marked this pull request as ready for review May 5, 2025 10:03
@TsunFengHuang TsunFengHuang mentioned this pull request May 5, 2025
Merged
6 tasks
@TsunFengHuang TsunFengHuang force-pushed the personal/TsunFeng/MockAdded branch 3 times, most recently from 6fb4684 to 63f2d9d Compare May 13, 2025 03:34
@TsunFengHuang TsunFengHuang force-pushed the personal/TsunFeng/MockAdded branch 2 times, most recently from 8fc6739 to b26e795 Compare May 19, 2025 03:59
@TsunFengHuang
Copy link
Author

Hi @lgao4, @mdkinney
Would you mind taking some time to review the PR when you have a changce?
Thank you!

@TsunFengHuang TsunFengHuang force-pushed the personal/TsunFeng/MockAdded branch from b26e795 to 4b747d9 Compare May 23, 2025 02:18
@mdkinney
Copy link
Member

The Sx is for Sleep State SMI, not Software SMIs. The description and comments need to be updated.

Also, there is both an SMM and an MM version of this protocol that are identical. This addition of a protocol mock should cover both the SMM and MM versions.

@TsunFengHuang TsunFengHuang force-pushed the personal/TsunFeng/MockAdded branch 3 times, most recently from 1bb85c1 to 267dfad Compare June 2, 2025 12:12
@TsunFengHuang
Copy link
Author

Hi @mdkinney
I have committed a change. Could you kindly review it and let me know if it meets your expectations?
Thank you for your time.

@TsunFengHuang TsunFengHuang force-pushed the personal/TsunFeng/MockAdded branch 2 times, most recently from e82643f to 2f7b722 Compare June 6, 2025 12:01
@TsunFengHuang TsunFengHuang force-pushed the personal/TsunFeng/MockAdded branch from 2f7b722 to 6a02628 Compare June 11, 2025 03:52
@TsunFengHuang
Copy link
Author

Hi @mdkinney,
Would you be able to review the PR when you have a moment? Thank you!

@github-actions
Copy link

This PR has been automatically marked as stale because it has not had activity in 60 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale Due to lack of updates, this item is pending deletion. label Aug 10, 2025
@mergify
Copy link

mergify bot commented Aug 10, 2025

PR can not be merged due to conflict. Please rebase and resubmit

@github-actions github-actions bot removed the stale Due to lack of updates, this item is pending deletion. label Aug 11, 2025
@github-actions
Copy link

This PR has been automatically marked as stale because it has not had activity in 60 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale Due to lack of updates, this item is pending deletion. label Oct 11, 2025
@github-actions
Copy link

This pull request has been automatically been closed because it did not have any activity in 60 days and no follow up within 7 days after being marked stale. Thank you for your contributions.

@github-actions github-actions bot closed this Oct 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lgao4 lgao4 lgao4 approved these changes

@mdkinney mdkinney Awaiting requested review from mdkinney

Assignees

No one assigned

Labels

stale Due to lack of updates, this item is pending deletion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TsunFengHuang @mdkinney @lgao4